Remove uncompleted sentence in Contributors guide. #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's already #247 open that tracks that. For now, I'll ship it, because |
lintonye
added a commit
to lintonye/react-navigation
that referenced
this pull request
Feb 22, 2017
* master: (55 commits) More gestures cleanup (react-navigation#353) CardStack: Don't overwrite custom transitionConfig with default (react-navigation#99) Update react-native-tab-view (react-navigation#366) Make future proof (and also fix it for the current beta) (react-navigation#322) Remove 'appBar' child component to fully support header styling (react-navigation#341) 1.0.0-beta.5 1.0.0-beta.4 Update yarn.lock to include react 15.4.2 Exported withNavigation to web (react-navigation#330) Overwrite 1x.ios as well Fix gesture recognition in card stack (react-navigation#324) Fix flow (react-navigation#305) adds button to photo screen (react-navigation#301) Add `showIcon` to `tabBarOptions` so that icons can be hidden on iOS (react-navigation#291) [FLOW] Fix missing "type" in flow import. Fix style prop for header Remove uncompleted sentence in Contributors guide. (react-navigation#280) Add missing characters to navigators api doc (react-navigation#264) Set numberOfLines to 1 for HeaderTitle (react-navigation#260) Add code sample for google analytics integration (react-navigation#107) ...
sourcecode911
pushed a commit
to sourcecode911/react-navigation
that referenced
this pull request
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, there is an uncompleted sentence in the Contributors guide.
@skevy wrote that line, if you remember what you wanted to write, ill add it :)
Otherwise, I just removed the floating words.