feat(drawer): add accessibilityCloseDrawerLabel option
#10027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @react-navigation/bottom-tabs@6.0.0-next.1 - @react-navigation/core@6.0.0-next.1 - @react-navigation/devtools@6.0.0-next.1 - @react-navigation/drawer@6.0.0-next.1 - @react-navigation/elements@1.0.0-next.1 - @react-navigation/material-bottom-tabs@6.0.0-next.1 - @react-navigation/material-top-tabs@6.0.0-next.1 - @react-navigation/native@6.0.0-next.1 - @react-navigation/routers@6.0.0-next.1 - @react-navigation/stack@6.0.0-next.1
…9405) Co-authored-by: Satyajit Sahoo <satyajit.happy@gmail.com>
- @react-navigation/stack@6.0.0-next.2
Custom insets can be provided by wrapping the navigator in a SafeAreaProvider, so we don't need an option.
- @react-navigation/bottom-tabs@6.0.0-next.2 - @react-navigation/drawer@6.0.0-next.2 - @react-navigation/elements@1.0.0-next.2 - @react-navigation/stack@6.0.0-next.3
- @react-navigation/stack@6.0.0-next.4
BREAKING CHANGE: headerMode is now moved to options instead of props
- @react-navigation/stack@6.0.0-next.5
- @react-navigation/stack@6.0.0-next.6
BREAKING CHANGE: now we need to pass a number instead of an object
- @react-navigation/stack@6.0.0-next.7
- @react-navigation/bottom-tabs@6.0.0-next.3 - @react-navigation/drawer@6.0.0-next.3 - @react-navigation/elements@1.0.0-next.3 - @react-navigation/stack@6.0.0-next.8
Thanks to software-mansion/react-native-screens#1071 (reply in thread). PR exposing `disableBackButtonMenu` from react-native-screens to `@react-navigation/native-stack` under new name - `headerBackButtonMenuEnabled`.
…ply any transformations This PR removes `transform` style from container and drawer views when the drawer type is set to be `permanent`. It does so to prevent cases where the `transform` CSS rule being present in a `web` context may cause other elements to no longer work correctly - see [this Chromium bug](https://bugs.chromium.org/p/chromium/issues/detail?id=20574) regarding `position:fixed`. I tried to stick to what I think to be the *intent* here, in that if the drawer type is set to be permanent, then no animation of the scene container or the drawer is ever intended in the future, and therefore, not having any `transform` present is desirable.
- @react-navigation/bottom-tabs@6.0.6 - @react-navigation/core@6.0.2 - @react-navigation/devtools@6.0.2 - @react-navigation/drawer@6.1.5 - @react-navigation/elements@1.1.1 - flipper-plugin-react-navigation@1.3.5 - @react-navigation/material-bottom-tabs@6.0.6 - @react-navigation/material-top-tabs@6.0.3 - @react-navigation/native-stack@6.2.0 - @react-navigation/native@6.0.3 - @react-navigation/stack@6.0.8
- @react-navigation/bottom-tabs@6.0.7 - @react-navigation/drawer@6.1.6 - @react-navigation/elements@1.1.2 - @react-navigation/material-bottom-tabs@6.0.7 - @react-navigation/material-top-tabs@6.0.4 - @react-navigation/native-stack@6.2.1 - @react-navigation/native@6.0.4 - @react-navigation/stack@6.0.9
- @react-navigation/native-stack@6.2.2
- @react-navigation/bottom-tabs@6.0.8 - @react-navigation/core@6.0.3 - @react-navigation/devtools@6.0.3 - @react-navigation/drawer@6.1.7 - @react-navigation/elements@1.2.0 - flipper-plugin-react-navigation@1.3.6 - @react-navigation/material-bottom-tabs@6.0.8 - @react-navigation/material-top-tabs@6.0.5 - @react-navigation/native-stack@6.2.3 - @react-navigation/native@6.0.5 - @react-navigation/routers@6.0.2 - @react-navigation/stack@6.0.10
|
✔️ Deploy Preview for react-navigation-example ready! 🔨 Explore the source changes: ed77be8 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-navigation-example/deploys/6163e930836f40000728197c 😎 Browse the preview: https://deploy-preview-10027--react-navigation-example.netlify.app/ |
Codecov Report
@@ Coverage Diff @@
## main #10027 +/- ##
==========================================
- Coverage 74.29% 74.28% -0.02%
==========================================
Files 159 159
Lines 4817 4819 +2
Branches 1819 1820 +1
==========================================
+ Hits 3579 3580 +1
- Misses 1204 1205 +1
Partials 34 34
Continue to review full report at Codecov.
|
satya164
requested changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #10026
Added
accessibilityCloseDrawerLabelto the drawer options to read the appropriate message when TalkBack focuses on the drawer overlay.