Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drawer): fix drawer when changing drawertype (ex: front -> permanent) #10304

Merged
merged 2 commits into from
Feb 1, 2022
Merged

fix(drawer): fix drawer when changing drawertype (ex: front -> permanent) #10304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37d03ca
fix(dawer): fix drawer when changing drawertype value from front to b…
sherif-cyber Jan 28, 2022
338f7c9
fix(drawer): remov using translatex on permanent mode
sherif-cyber Jan 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/drawer/src/views/legacy/Drawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,7 @@ export default class DrawerView extends React.Component<DrawerProps> {
drawerType === 'permanent'
? // Reanimated needs the property to be present, but it results in Browser bug
// https://bugs.chromium.org/p/chromium/issues/detail?id=20574
undefined
[]
: [{ translateX: contentTranslateX }],
},
]}
Expand Down Expand Up @@ -619,7 +619,7 @@ export default class DrawerView extends React.Component<DrawerProps> {
drawerType === 'permanent'
? // Reanimated needs the property to be present, but it results in Browser bug
// https://bugs.chromium.org/p/chromium/issues/detail?id=20574
undefined
[]
: [{ translateX: drawerTranslateX }],
opacity: this.drawerOpacity,
},
Expand Down
4 changes: 2 additions & 2 deletions packages/drawer/src/views/modern/Drawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ export default function Drawer({
drawerType === 'permanent'
? // Reanimated needs the property to be present, but it results in Browser bug
// https://bugs.chromium.org/p/chromium/issues/detail?id=20574
undefined
[]
: [
{
translateX: drawerType === 'back' ? 0 : translateX.value,
Expand All @@ -280,7 +280,7 @@ export default function Drawer({
drawerType === 'permanent'
? // Reanimated needs the property to be present, but it results in Browser bug
// https://bugs.chromium.org/p/chromium/issues/detail?id=20574
undefined
[]
: [
{
translateX:
Expand Down