Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct supported react-native-reanimated version #11378

Closed
wants to merge 1 commit into from

Conversation

nikgraf
Copy link
Contributor

@nikgraf nikgraf commented May 18, 2023

Motivation

After upgrading expo I got this error message:

Invalid RNReanimated.podspec file: [react-native-reanimated] Multiple versions of Reanimated were detected. Only one instance of react-native-reanimated can be installed in a project. You need to resolve the conflict manually. Check out the documentation: https://docs.swmansion.com/react-native-reanimated/docs/next/fundamentals/troubleshooting#multiple-versions-of-reanimated-were-detected

I noticed due the react-navigation peerDependency specification 1.x of reanimated was installed. After realizing that you do support reanimated 2 & 3 I investigated and found this example: https://stackoverflow.com/a/47310882/837709

Test plan

Everything should work as before.

@netlify
Copy link

netlify bot commented May 18, 2023

Deploy Preview for react-navigation-example failed.

Name Link
🔨 Latest commit 44b4920
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-example/deploys/646635f77e24610008142ceb

@nikgraf
Copy link
Contributor Author

nikgraf commented May 21, 2023

Now I'm not sure this actually adds value or would fix the issue. It was a false positive as described here: software-mansion/react-native-reanimated#3509 (comment)

@kacperkapusciak
Copy link
Member

Hi, thanks for a PR but I can't merge this as the changes you've proposed aren't related to the problem

Cheers ✌️

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Hey! This issue is closed and isn't watched by the core team. You are welcome to discuss the issue with others in this thread, but if you think this issue is still valid and needs to be tracked, please open a new issue with a repro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants