-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add a direction prop to NavigationContainer to specify rtl #11393
Conversation
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #11393 +/- ##
==========================================
+ Coverage 75.43% 75.59% +0.16%
==========================================
Files 189 191 +2
Lines 5712 5713 +1
Branches 2254 2238 -16
==========================================
+ Hits 4309 4319 +10
+ Misses 1353 1344 -9
Partials 50 50
☔ View full report in Codecov by Sentry. |
The Expo app for the example from this branch is ready! |
…/ltr BREAKING CHANGE: Previously the navigators tried to detect RTL automatically and adjust the UI. However this is problematic since we cannot detect RTL in all cases (e.g. on Web). This adds an optional `direction` prop to `NavigationContainer` instead so that user can specify when React Navigation's UI needs to be adjusted for RTL.
57017e0
to
0577497
Compare
@satya164 I can't find such |
Hey! This issue is closed and isn't watched by the core team. You are welcome to discuss the issue with others in this thread, but if you think this issue is still valid and needs to be tracked, please open a new issue with a repro. |
BREAKING CHANGE: Previously the navigators tried to detect RTL automatically and
adjust the UI. However this is problematic since we cannot detect RTL in all cases
(e.g. on Web).
This adds an optional
direction
prop toNavigationContainer
insteadso that user can specify when React Navigation's UI needs to be adjusted for RTL. It defaults to the value from
I18nManager
on native platforms, however it needs to be explicitly passed for Web.