Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Stack): added failed gesture state to clear interaction #11465

Conversation

Iltimirov
Copy link
Contributor

@Iltimirov Iltimirov commented Jul 11, 2023

Added failed gesture state to clear interaction manager queue

Motivation

My team ran into an issue on IOS where the user taps somewhere on the left edge of the screen without any swipe, and upon releasing their finger, the InteractionManager has one outstanding task in the queue. And this task can block user interactions wrapped into InteractionManager.runAfterInteractions

It could be related with #8606 but i'm not sure

Test plan

  1. Create a stack with two screen with an ability to navigate by swipe
  2. Navigate from screen (1) to screen (2)
  3. Tap somewhere in the left edge of the screen
  4. After that all actions wrapped into InteractionManager.runAfterInteractions will not work

@github-actions
Copy link

Hey @Iltimirov! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for react-navigation-example ready!

Name Link
🔨 Latest commit 0b6ba2e
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-example/deploys/65c4d0eadc9030000863b773
😎 Deploy Preview https://deploy-preview-11465--react-navigation-example.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@satya164 satya164 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@satya164 satya164 enabled auto-merge (squash) February 8, 2024 13:03
@satya164 satya164 merged commit 1b56cb5 into react-navigation:main Feb 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants