-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: buggy behaviour of search bar / large title on Fabric with native stack v7 #11501
fix: buggy behaviour of search bar / large title on Fabric with native stack v7 #11501
Conversation
Hey @kkafar! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #11501 +/- ##
==========================================
- Coverage 75.50% 75.48% -0.02%
==========================================
Files 190 190
Lines 5739 5740 +1
Branches 2261 2260 -1
==========================================
Hits 4333 4333
- Misses 1359 1360 +1
Partials 47 47
☔ View full report in Codecov by Sentry. |
Hey @autofix-ci[bot]! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
4b8696e
to
ae7ff24
Compare
Asking for a review @kacperkapusciak |
eac9393
to
8ce8cd4
Compare
Header customization in native stack got broken in #11501. This change fixes it.
Motivation
UIKit
requiresScrollView
to be at index 0 in given view's subview array to enable it's interaction with navigation bar. On FabricDebugContainer
view got flattened, however it was not removed from hierarchy -- instead the view was attached as first child of theRNSScreenView
disabling system interaction between navigation bar and a scroll view.See
for broader context and explanation.
Test plan
Before
Simulator.Screen.Recording.-.iPhone.14.-.2023-07-18.at.23.31.05.mp4
After
Simulator.Screen.Recording.-.iPhone.14.-.2023-07-18.at.23.28.42.mp4