Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: buggy behaviour of search bar / large title on Fabric with native stack v7 #11501

Merged
merged 9 commits into from
Jul 31, 2023

Conversation

kkafar
Copy link
Contributor

@kkafar kkafar commented Jul 26, 2023

Motivation

UIKit requires ScrollView to be at index 0 in given view's subview array to enable it's interaction with navigation bar. On Fabric DebugContainer view got flattened, however it was not removed from hierarchy -- instead the view was attached as first child of the RNSScreenView disabling system interaction between navigation bar and a scroll view.

See

for broader context and explanation.

Test plan

Before

Simulator.Screen.Recording.-.iPhone.14.-.2023-07-18.at.23.31.05.mp4

After

Simulator.Screen.Recording.-.iPhone.14.-.2023-07-18.at.23.28.42.mp4

@github-actions
Copy link

Hey @kkafar! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for react-navigation-example ready!

Name Link
🔨 Latest commit f0ef79c
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-example/deploys/64c7a49107ab9e000850636d
😎 Deploy Preview https://deploy-preview-11501--react-navigation-example.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kkafar kkafar changed the base branch from main to 6.x July 26, 2023 12:33
@kkafar kkafar changed the base branch from 6.x to main July 26, 2023 12:39
@kkafar kkafar changed the title fix: buggy behaviour of search bar / large title on Fabric with native stack fix: buggy behaviour of search bar / large title on Fabric with native stack v7 Jul 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.02% ⚠️

Comparison is base (24c0392) 75.50% compared to head (f0ef79c) 75.48%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11501      +/-   ##
==========================================
- Coverage   75.50%   75.48%   -0.02%     
==========================================
  Files         190      190              
  Lines        5739     5740       +1     
  Branches     2261     2260       -1     
==========================================
  Hits         4333     4333              
- Misses       1359     1360       +1     
  Partials       47       47              
Files Changed Coverage Δ
packages/drawer/src/views/DrawerView.tsx 64.19% <0.00%> (ø)
.../native-stack/src/views/NativeStackView.native.tsx 78.94% <42.85%> (ø)
...s/native-stack/src/views/DebugContainer.native.tsx 87.50% <66.66%> (-12.50%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Hey @autofix-ci[bot]! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

@kkafar kkafar force-pushed the @kkafar/fix-searchbar-fabric branch from 4b8696e to ae7ff24 Compare July 26, 2023 13:18
@kkafar
Copy link
Contributor Author

kkafar commented Jul 27, 2023

Asking for a review @kacperkapusciak

@satya164 satya164 force-pushed the @kkafar/fix-searchbar-fabric branch from eac9393 to 8ce8cd4 Compare July 31, 2023 12:01
@satya164 satya164 merged commit dcb4e4c into react-navigation:main Jul 31, 2023
8 checks passed
satya164 added a commit that referenced this pull request Nov 3, 2023
Header customization in native stack got broken in #11501. This change fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants