Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optimize route cache #11547

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Conversation

okwasniewski
Copy link
Contributor

Optimize route cache to prevent re-rendering.

Motivation

Routes shouldn't re-render, we are now using route key as the cache key

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (d8dc693) 75.67% compared to head (ee81330) 75.69%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11547      +/-   ##
==========================================
+ Coverage   75.67%   75.69%   +0.02%     
==========================================
  Files         194      194              
  Lines        5775     5776       +1     
  Branches     2274     2274              
==========================================
+ Hits         4370     4372       +2     
+ Misses       1358     1357       -1     
  Partials       47       47              
Files Changed Coverage Δ
packages/core/src/useRouteCache.tsx 93.75% <100.00%> (+0.41%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@netlify
Copy link

netlify bot commented Aug 19, 2023

Deploy Preview for react-navigation-example ready!

Name Link
🔨 Latest commit ee81330
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-example/deploys/64f5e568c3b0b80008211863
😎 Deploy Preview https://deploy-preview-11547--react-navigation-example.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@okwasniewski okwasniewski marked this pull request as draft August 19, 2023 14:32
@okwasniewski
Copy link
Contributor Author

@satya164 satya164 marked this pull request as ready for review September 4, 2023 14:10
@satya164 satya164 merged commit 2c0f604 into main Sep 4, 2023
8 checks passed
@satya164 satya164 deleted the fix/okwasniewski/optimizeRouteCache branch September 4, 2023 14:26
@ranaavneet
Copy link

Shouldn't this be back-ported as well?

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Hey! This issue is closed and isn't watched by the core team. You are welcome to discuss the issue with others in this thread, but if you think this issue is still valid and needs to be tracked, please open a new issue with a repro.

@satya164
Copy link
Member

satya164 commented Oct 3, 2023

no, it's a breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants