-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: optimize route cache #11547
fix: optimize route cache #11547
Conversation
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #11547 +/- ##
==========================================
+ Coverage 75.67% 75.69% +0.02%
==========================================
Files 194 194
Lines 5775 5776 +1
Branches 2274 2274
==========================================
+ Hits 4370 4372 +2
+ Misses 1358 1357 -1
Partials 47 47
☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The Expo app for the example from this branch is ready! |
Make sure this works before merging: https://reactnavigation.org/docs/7.x/screen-options-resolution/#setting-parent-screen-options-based-on-child-navigators-state |
Shouldn't this be back-ported as well? |
Hey! This issue is closed and isn't watched by the core team. You are welcome to discuss the issue with others in this thread, but if you think this issue is still valid and needs to be tracked, please open a new issue with a repro. |
no, it's a breaking change |
Optimize route cache to prevent re-rendering.
Motivation
Routes shouldn't re-render, we are now using route key as the cache key