Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement tab-view new api #11548

Merged
merged 11 commits into from
Mar 4, 2024
Merged

Conversation

okwasniewski
Copy link
Contributor

Motivation

Implement a new API to address performance issues with current implementation.

Test plan

Go through the examples and test that they work

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2023

Codecov Report

Attention: Patch coverage is 50.00000% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 77.12%. Comparing base (b407411) to head (bb8ed5e).

Files Patch % Lines
packages/react-native-tab-view/src/TabBar.tsx 36.66% 19 Missing ⚠️
packages/react-native-tab-view/src/TabBarItem.tsx 58.82% 6 Missing and 1 partial ⚠️
.../material-top-tabs/src/views/MaterialTopTabBar.tsx 64.70% 5 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11548      +/-   ##
==========================================
+ Coverage   76.96%   77.12%   +0.15%     
==========================================
  Files         208      208              
  Lines        6135     6115      -20     
  Branches     2406     2399       -7     
==========================================
- Hits         4722     4716       -6     
+ Misses       1359     1345      -14     
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@netlify
Copy link

netlify bot commented Aug 19, 2023

Deploy Preview for react-navigation-example ready!

Name Link
🔨 Latest commit bb8ed5e
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-example/deploys/65e625765ebaed0008abc462
😎 Deploy Preview https://deploy-preview-11548--react-navigation-example.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@okwasniewski okwasniewski force-pushed the @okwasniewski/tab-view/new-api branch 3 times, most recently from 55b2bd5 to 414c1dc Compare August 22, 2023 08:00
@okwasniewski okwasniewski marked this pull request as ready for review August 24, 2023 07:24
@okwasniewski okwasniewski linked an issue Aug 24, 2023 that may be closed by this pull request
11 tasks
Copy link

github-actions bot commented Jan 7, 2024

Hey @autofix-ci[bot]! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines.

# Conflicts:
#	packages/material-top-tabs/src/views/MaterialTopTabBar.tsx
@satya164 satya164 enabled auto-merge (squash) March 4, 2024 19:48
@satya164 satya164 merged commit dca15c9 into main Mar 4, 2024
8 checks passed
@satya164 satya164 deleted the @okwasniewski/tab-view/new-api branch March 4, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

material-top-tabs slow render
4 participants