Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retaining of the screen to the stack navigator #11765

Merged
merged 4 commits into from Dec 28, 2023
Merged

Conversation

osdnk
Copy link
Member

@osdnk osdnk commented Dec 22, 2023

The changes are pretty straightforward and should be expressive enough to understand by reading the codebase. This PR:

To test, try the example.

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (1a8ea15) 76.63% compared to head (684cd48) 76.74%.
Report is 3 commits behind head on main.

Files Patch % Lines
packages/native/src/useLinkBuilder.tsx 33.33% 2 Missing ⚠️
packages/stack/src/views/Stack/CardStack.tsx 66.66% 2 Missing ⚠️
packages/routers/src/StackRouter.tsx 91.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11765      +/-   ##
==========================================
+ Coverage   76.63%   76.74%   +0.10%     
==========================================
  Files         207      207              
  Lines        6095     6101       +6     
  Branches     2377     2384       +7     
==========================================
+ Hits         4671     4682      +11     
+ Misses       1372     1367       -5     
  Partials       52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for react-navigation-example ready!

Name Link
🔨 Latest commit 684cd48
🔍 Latest deploy log https://app.netlify.com/sites/react-navigation-example/deploys/658c1a7f1cdab40008dc2da4
😎 Deploy Preview https://deploy-preview-11765--react-navigation-example.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@osdnk osdnk merged commit 7fe82f7 into main Dec 28, 2023
8 checks passed
@osdnk osdnk deleted the @osdnk/retain branch December 28, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants