fix: browser navigating out after using back feature and going home #11833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @SlickDomique! Thanks for opening your first pull request in this repo. If you haven't already, make sure to read our contribution guidelines. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## 6.x #11833 +/- ##
==========================================
- Coverage 74.19% 74.19% -0.01%
==========================================
Files 178 178
Lines 5623 5626 +3
Branches 2216 2219 +3
==========================================
+ Hits 4172 4174 +2
- Misses 1402 1403 +1
Partials 49 49 ☔ View full report in Codecov by Sentry. |
haileyok
added a commit
to bluesky-social/social-app
that referenced
this pull request
Feb 21, 2024
haileyok
added a commit
to bluesky-social/social-app
that referenced
this pull request
Feb 22, 2024
* patch react-navigation - react-navigation/react-navigation#11833 * add readme
osdnk
pushed a commit
that referenced
this pull request
Feb 23, 2024
…11833) **Motivation** Fix for #11832 Before going to negative history index check if the history will return anything for that index. If that's not the case the previous behavior would open previously opened page from that tab. **Test plan** From my testing project you can test it by To replicate the issue in my example open the app and do: 1. Open new tab and go to any page. After that manually put the app address to the address bar and navigate to it. 2. Navigate with menu to PageA 3. Navigate with menu to PageB 4. Use browser go back (can be button, keyboard shortcut or mouse button) 5. Navigate with menu to PageB again 6. Try navigating Home with menu 7. You will no longer get redirected to a previous page from step 0 but to the home page instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix for #11832
Before going to negative history index check if the history will return anything for that index. If that's not the case the previous behavior would open previously opened page from that tab.
Test plan
From my testing project you can test it by
To replicate the issue in my example open the app and do: