-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Make all screens after presentation: 'modal' as modal unless specified #11860
fix: Make all screens after presentation: 'modal' as modal unless specified #11860
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #11860 +/- ##
==========================================
+ Coverage 76.99% 77.02% +0.02%
==========================================
Files 207 209 +2
Lines 6151 6171 +20
Branches 2420 2430 +10
==========================================
+ Hits 4736 4753 +17
- Misses 1361 1364 +3
Partials 54 54 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for react-navigation-example ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other thing to check is if we also need to consider transparentModal
along with modal
from my perspective automatically stack for 'modal' looks logical but 'transparentModal' can be a little mess with all these transparent screens stack |
We shouldn't mark all screens after |
Make all screens after presentation: 'modal' as modal unless specified