apply params state change during navigate in TabRouter #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericvicenti
requested changes
Feb 2, 2017
| @@ -129,6 +129,10 @@ export default ( | |||
| } | |||
| if (activeTabIndex !== state.index) { | |||
| // console.log(`${order.join('-')}: Normal navigation`, {lastIndex: state.index, newIndex: activeTabIndex}); | |||
| if ( action.params ) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
| @@ -129,6 +129,10 @@ export default ( | |||
| } | |||
| if (activeTabIndex !== state.index) { | |||
| // console.log(`${order.join('-')}: Normal navigation`, {lastIndex: state.index, newIndex: activeTabIndex}); | |||
| if ( action.params ) { | |||
| state = {...state, routes: [...state.routes]}; | |||
| state.routes[activeTabIndex] = {...state.routes[activeTabIndex], params: action.params}; | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This was referenced Feb 2, 2017
Closed
|
Any updates on this @danj3 ? |
|
I hope to attend to the changes shortly. |
|
any progress on this? |
|
This is a pretty simple and high-pri fix. @danj3, any updates? If anybody else wants to address the feedback and submit a PR for this, we can land it sooner rather than later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue #80
paramsis not merged into state during the Navigation dispatch, so is unavailable to the Screen. I make no claim of understanding this code base, however, running through the nav transitions in the debugger led me to conclude that this is simply not handled. If it is handled then there is a documentation hole explaining how it is supposed to work, though I don't know what that would be.Test
Object transition during action with params, attached png