Feature/toggle #2492
Merged
Feature/toggle #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,6 +63,12 @@ export default class DrawerView<T: *> extends PureComponent<void, Props, void> { | |||
| const { routes, index } = nextProps.navigation.state; | |||
| if (routes[index].routeName === 'DrawerOpen') { | |||
| this._drawer.openDrawer(); | |||
| } else if (routes[index].routeName === 'DrawerToggle') { | |||
| if (this._drawer.state.drawerShown) { | |||
| this.props.navigation.navigate('DrawerClose'); | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
davepack
approved these changes
Aug 29, 2017
sourcecode911
pushed a commit
to sourcecode911/react-navigation
that referenced
this pull request
Mar 9, 2020
* add toggle functionality * add documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every drawer menu needs a toggle. Especially when navigating to a drawer 'DrawerOpen' twice can cause bugs/issues. To solve this currently everyone needs to know about drawer state and structure, which causes code to look like so:
This is not readable or future-proof. Instead toggle should be a first class citizen of drawers.
That is what this PR includes. Also updates docs.