Fix Website Build #2526
Merged
Fix Website Build #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ReferenceError when not in the React Native environment.
spencercarli
commented
Sep 5, 2017
src/utils/invariant.js
Outdated
| @@ -24,7 +24,7 @@ | |||
|
|
|||
| var validateFormat = function(format) {}; | |||
|
|
|||
| if (__DEV__) { | |||
| if (global.__DEV__) { | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Looks like it built correctly on my machine 🎉, awesome 😄 ! Not sure about the implications of changing |
sourcecode911
pushed a commit
to sourcecode911/react-navigation
that referenced
this pull request
Mar 9, 2020
* Update .eslintrc to allow compile. * Resolve .web.js extension * Look for __DEV__ on global Fixes ReferenceError when not in the React Native environment. * Replace __DEV__ at compile time via babel * Don't try to lint a website build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix website build so we can get doc updates live.
Test Plan
Follow instructions in
website/README.mdto build the site.