Fixing Intro Guide #2679
Merged
Fixing Intro Guide #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #832 - the code in this page was wrong, that export default was causing errors. I've also modified a few phrases here and there to help the comprehension.
|
I've tested the code locally and with that fix it works fine, but always better to get an extra pair of eyes on it - @spencercarli or @matthamil can you just take a quick look so that we can merge and help introducing new people to |
spencercarli
reviewed
Oct 1, 2017
| @@ -66,7 +68,7 @@ class HomeScreen extends React.Component { | |||
| } | |||
| } | |||
|
|
|||
| export default const SimpleApp = StackNavigator({ | |||
| export const SimpleApp = StackNavigator({ | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Closed
|
Updated my PR to make it work with CRNA & Expo |
GantMan
approved these changes
Oct 3, 2017
sourcecode911
pushed a commit
to sourcecode911/react-navigation
that referenced
this pull request
Mar 9, 2020
* Fixing Intro Guide Fixes react-navigation#832 - the code in this page was wrong, that export default was causing errors. I've also modified a few phrases here and there to help the comprehension. * more fixes, for CRNA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #832 - the code in this page was wrong, that
export defaultwas causing errors.I've also modified a few phrases here and there to help the comprehension.