fix 2953 (Deep Linking - related) #2976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2976 +/- ##
==========================================
- Coverage 66.8% 66.68% -0.12%
==========================================
Files 51 51
Lines 1479 1483 +4
Branches 369 370 +1
==========================================
+ Hits 988 989 +1
- Misses 385 388 +3
Partials 106 106
Continue to review full report at Codecov.
|
kelset
approved these changes
Nov 14, 2017
|
Thanks @vonovak for the fix |
RonnieRen
pushed a commit
to RonnieRen/react-navigation
that referenced
this pull request
Nov 17, 2017
* master: (63 commits) Move SafeAreaView out of DrawerNavigatorItems to DrawerSidebar. (react-navigation#2967) Allow custom header and back button to use the props from react-navigation (react-navigation#2712) Update Guide-Headers.md (react-navigation#2949) fix 2953 (react-navigation#2976) prevent error `RawText "" must be wrapped in an explicit <Text> compo… (react-navigation#2415) Update TabBarBottom to accept styling for animations (react-navigation#2945) Improve Contributing Guide (react-navigation#2960) Added a guide under intermediate concepts. (react-navigation#2958) SafeAreaView - Fix for Web usage (react-navigation#2950) Fix 'good first issue' link in README (react-navigation#2919) [Docs] Fix Comparisons Link in Readme (react-navigation#2910) Export all Flow types from TypeDefinition (react-navigation#2903) Fix issue react-navigation#618 - TabBarBottom should hide itself when Keyboard is activated (react-navigation#1764) Bump to beta.19 Add back Header.HEIGHT but with a deprecation warning improve wording in router docs (react-navigation#2894) add 2nd params argument to StackRouter.getActionForPathAndParams (react-navigation#1623) Bump version SafeAreaView padding from style prop (react-navigation#2889) Safe area example (react-navigation#2890) ... # Conflicts: # src/views/CardStack/CardStackStyleInterpolator.js # src/views/Header/Header.js # src/views/Header/HeaderStyleInterpolator.js
|
This is a breaking change because this will cause action |
|
@leethree can you please an issue related to this, if it still happens in |
|
@leethree good point. This fix was kinda short-sighted in this respect. Maybe we should change the default |
rpopovici
pushed a commit
to rpopovici/react-navigation
that referenced
this pull request
Jan 16, 2018
sourcecode911
pushed a commit
to sourcecode911/react-navigation
that referenced
this pull request
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #2953, deep linking with uri that contains query params does not work anymore on master. query params are not passed down the state params.
inputParams is by default equal to {} as can be seen here, therefore, queryParams returns always {} even if queryString is not empty.
Test plan:
tested by the author of #2953 as seen here