Fixed the Header Title Center bug on Android #4248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NavigationPlayground for a9281eb has been deployed. |
|
hi there! this behavior is intentional. by default on android the text is aligned to the left. open issue on rfcs for this: react-navigation/rfcs#38 if you'd like to open a rfc on that repo please do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Title in the header of the Stack Navigator wasn't centred by default for Android Devices and was set to 'flex-start' for any devices without iOS.
The main motivation was when I was trying to build an Instagram UI Clone in React Native on Android. I used the title in navigation options and saw that the title wasn't centred by default for Android devices whereas it was for the iOS devices. I had a look at the Header source code and figured out that for devices other than iOS, the value should be 'centre' instead of 'flex-start' which indeed solved the issue.
Please refer to the screenshots below and after the changes:
Before
After
Everything works fine on iOS by default but I guess this fixes the problem on Android devices.