Error when building with haul: ref to pathToRegexp.compile #4658
Conversation
|
NavigationPlayground for e5f69ad has been deployed. |
|
Erm this is strange.. we're using normal documented behavior of pathToRegexp here.. https://github.com/pillarjs/path-to-regexp I'm not sure whats going on with haul cc @satya164 |
ericvicenti
changed the title
|
cc @thymikee |
|
I think it's a quirk in Babel acutally. And haul's failure indicates correct behavior (imho). Wouldn't a module like that be imported like this?: -import pathToRegexp from 'path-to-regexp';
+import * as pathToRegexp from 'path-to-regexp';The documentation uses require, so I'd assume you either do the above or: import {compile} from 'path-to-regexp';
compile(...) |
|
Oh, very strange that it somehow works in metro. I'm not a fan of @Piotrovskyi, can you change this PR to import compile with |
Codecov Report
@@ Coverage Diff @@
## master #4658 +/- ##
=======================================
Coverage 67.75% 67.75%
=======================================
Files 57 57
Lines 1833 1833
=======================================
Hits 1242 1242
Misses 591 591
Continue to review full report at Codecov.
|
|
@ericvicenti - look good to you now? |
|
NavigationPlayground for 821f355 has been deployed. |
There was a problem hiding this comment.
Entry in changelog is missing as defined in the pull request template.
|
NavigationPlayground for 58df7ed has been deployed. |
There was a problem hiding this comment.
Thanks for adding the entry. However, you should add it under the existing "Fixed" section as shown here.
|
NavigationPlayground for 58df7ed has been deployed. |
|
NavigationPlayground for adeaaf6 has been deployed. |
|
NavigationPlayground for 80d46a9 has been deployed. |
|
@brentvatne About the changelog entry, now that I think about it… It should be add under the Unreleased section, right? |
|
NavigationPlayground for de652a2 has been deployed. |
|
NavigationPlayground for 1efc42a has been deployed. |
Please provide enough information so that others can review your pull request:
Motivation
Error in source code that cause problem on react native using haul https://puu.sh/AT1uZ/158623d5a4.png