Extract stack to react-navigation-stack #4809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NavigationPlayground for 62e6534 has been deployed. |
|
NavigationPlayground for bd0a150 has been deployed. |
Codecov Report
@@ Coverage Diff @@
## master #4809 +/- ##
==========================================
+ Coverage 67.49% 71.65% +4.15%
==========================================
Files 57 42 -15
Lines 1843 1083 -760
==========================================
- Hits 1244 776 -468
+ Misses 599 307 -292
Continue to review full report at Codecov.
|
ericvicenti
reviewed
Aug 3, 2018
| @@ -4,7 +4,9 @@ import { StyleSheet, View } from 'react-native'; | |||
| import renderer from 'react-test-renderer'; | |||
|
|
|||
| import NavigationActions from '../NavigationActions'; | |||
| import createStackNavigator from '../navigators/createStackNavigator'; | |||
|
|
|||
| // TODO: we should create a dummy navigator here | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make it easier to work on / for people to test an alternative stack built on top of screen components while staying up to date with any upstream changes.
Test plan
Run navigation playground