Add drawerLockMode to DrawerView

[martnu]

This allows us to disable the gesture to open the drawer. Related to #390.

[zoontek]

This PR will simplify a LOT our navigation. Thanks! :D

[ferrannp]

Did you test that locked-open ? Because I tried doing this PR and I couldn't make the option to work and I didn't spend more time on it. I understand that if I choose locked-open, the drawer should be opened by default right? And that is controlled by the navigation state so probably we need to add some logic ? cc @satya164

[satya164]

cc @DanielMSchmidt

[DanielMSchmidt]

@ferrannp AFAIK lock-open is implemented both in Android as well as in the react-native-drawer-layout-polyfill as "When the drawer is open, don't let it close". This does not include opening it as the property gets set. If you experience a different behaviour on Android, please let me know.

@martnu PR looks nice, thank you for your effort!

[ferrannp]

@DanielMSchmidt right mmm, it would be nice thought to provide a prop as initial state of the drawer (closed or open) and then I can use it together with locked-open to be able for example to develop for tablets.

[satya164]

Probably better to just use a plain view on tablets. You don't need any of drawer's behaviour.

[ghost]

MUCH NEEDED!

[DanielMSchmidt]

@satya164 @martnu How can I help getting this merged ASAP?

[martnu]

@DanielMSchmidt I just updated the branch, but after CI runs I'm just waiting for a merge.

[satya164]

I think it makes more sense in navigationOptions. You cannot change this option dynamically, so it doesn't really do anything. A drawer navigator with always locked drawer? not very useful.

[martnu]

@satya164 It is useful since it allows us to only open/close the drawer programmatically and not via touch gestures since that currently conflicts with the default swipe-back behavior in a stack. I do agree that it would be nice to have it configured for each screen but I'd have to look into the code a bit more.

[satya164]

How can you change this programmatically?

[martnu]

@satya164 We can't change the behavior for the drawer, but I can open the Drawer programmatically via navigate('DrawerOpen').

[satya164]

I see.

Anyway, we should add it to navigationOptions since we will need that, and it will not be very nice to have the same config in 2 places.

[satya164]

CI is failing. You probably need to fix the flow types.

[j-mendez]

How to update the lock-mode dynamically? Currently setting these options only work when you do it in the DrawerNavigator options and cannot be updated. When I try to use static navigationOptions for the drawer nothing happens. I declare it on the contentComponent. Even using a global for the value for lockMode will not cause it to update when needed.
.

[nishiltamboli]

Yes this is much needed feature. Will solve a lot of problems.

[maximromanyuk]

@mmerickel Are you able to fix it?

[matzero]

If you fork the library and patched it with the PR code, it works but
Why you no merge!

[mukurpuri]

Hello!! Is anyone there? This PR is critically important, I will clone this repo and work with you for this.

[williamdes]

Exactly, do it :)

[vonovak]

seems like #1377 is a better PR than this one since it allows to specify this within navigationOptions

[sospedra]

Hmmm 🤔 So, what's happening? Why a highly-requested 6 months-ago PR is not merged? Is there any reason? I mean, it's not even a feature. We're just passing down a prop to another lib which is doing the work behind. No big deal, no?

[sibelius]

can we get this or #1377 merge in?

This solves some real app use cases

[maximromanyuk]

@sibelius there is some issues someone need to fix

[kelset]

There are conflicts in src/TypeDefinition.js - can you fix them?

[antofa]

any update?

[guilhermedecampo]

@spencercarli I read on a blog post that you'll work here on react-navigation to take a look on documentation and issues can you give a heads up about this one here?

We are building an app that this is primordial. There is any timeline or another PR, issue etc that people are working for this feature? Definitely we can help in any means.
Best,

[spencercarli]

@guilhermedecampo going to try to get this merged asap. I'm not super familiar with drawers so I'm going to have someone else look it over. Looks good to me though

[GantMan]

This looks/feels great

Not sure what CI is complaining about, I forever get a spinner on the message, but the code looks great to me @spencercarli

[GantMan]

besides this, it looks great.

[vonovak]

@spencercarli please note this PR does not allow to specify drawer lock mode in navigation options and several people already expressed they need that. There is another pr that I linked a couple of posts higher which should be able to do that, it might be good to take a look at it.

[GantMan]

@spencercarli - I agree with @vonovak

After reviewing both PRs, I find #1377 better.

We might need to make drawer lock mode optional in the type and implementation but that would be a small patch, I'm sure everyone is up for.

[janzal]

Agree with @vonovak. +1

[spencercarli]

Ok we'll go with #1337 instead (thanks for pointing that out again @vonovak). It just needs a bit of work to get tests passing then we can ship it

[spencercarli]

Just merged #1377 in! Thanks for everyone's work and input on this. Will be in the next release 😄

[t407289575]

Hold coming soon !!! @spencercarli

[jacktan165]

Wait it's being fixed!? I actually lost hope, only checking on this status once per month! Thanks guys!

[giantss]

const navigationOptions = ({navigation}) => ({
  //Other configuration items are omitted
    drawerLockMode:'locked-closed' //here
});


const MainStackNavigator = StackNavigator({
    Chat:{
        screen: Chat,
        navigationOptions:{   
             drawerLockMode:'unlocked',  //here
        }
    }
  //Other configuration items are omitted
},{
    navigationOptions: navigationOptions,
    initialRouteName: 'Chat', //home page
});