feat: add props from native Screen component #9458
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for react-navigation-example ready! 🔨 Explore the source changes: 2da692d 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-navigation-example/deploys/61f967f24b61bd000823e228 😎 Browse the preview: https://deploy-preview-9458--react-navigation-example.netlify.app/ |
|
The Expo app for the example from this branch is ready! expo.io/@react-navigation/react-navigation-example?release-channel=pr-9458 |
- @react-navigation/bottom-tabs@6.0.0-next.7 - @react-navigation/core@6.0.0-next.4 - @react-navigation/devtools@6.0.0-next.4 - @react-navigation/drawer@6.0.0-next.6 - @react-navigation/elements@1.0.0-next.6 - @react-navigation/material-bottom-tabs@6.0.0-next.4 - @react-navigation/material-top-tabs@6.0.0-next.5 - @react-navigation/native@6.0.0-next.4 - @react-navigation/stack@6.0.0-next.11
- @react-navigation/bottom-tabs@6.0.0-next.8 - @react-navigation/core@6.0.0-next.5 - @react-navigation/devtools@6.0.0-next.5 - @react-navigation/drawer@6.0.0-next.7 - @react-navigation/elements@1.0.0-next.7 - @react-navigation/material-bottom-tabs@6.0.0-next.5 - @react-navigation/material-top-tabs@6.0.0-next.6 - @react-navigation/native@6.0.0-next.5 - @react-navigation/stack@6.0.0-next.12
- @react-navigation/bottom-tabs@6.0.0-next.9 - @react-navigation/core@6.0.0-next.6 - @react-navigation/devtools@6.0.0-next.6 - @react-navigation/drawer@6.0.0-next.8 - @react-navigation/elements@1.0.0-next.8 - @react-navigation/material-bottom-tabs@6.0.0-next.6 - @react-navigation/material-top-tabs@6.0.0-next.7 - @react-navigation/native@6.0.0-next.6 - @react-navigation/stack@6.0.0-next.13
- @react-navigation/stack@6.0.0-next.14
- @react-navigation/bottom-tabs@6.0.0-next.10 - @react-navigation/core@6.0.0-next.7 - @react-navigation/devtools@6.0.0-next.7 - @react-navigation/drawer@6.0.0-next.9 - @react-navigation/elements@1.0.0-next.9 - @react-navigation/material-bottom-tabs@6.0.0-next.7 - @react-navigation/material-top-tabs@6.0.0-next.8 - @react-navigation/native@6.0.0-next.7 - @react-navigation/stack@6.0.0-next.15
Reanimated has a bug where it doesn't update the `transform` property from what was set before if the new style object doesn't include it. We don't want to add a `transform` when not needed due to browser bugs (https://bugs.chromium.org/p/chromium/issues/detail?id=20574). This commit adds `transform: undefined` explicitly to workaround the bug in Reanimated while still resulting on the style not being included to avoid the browser bug. Fixes #10210
While passing a component with an uncapitalized name works, it can mean that the user is trying to pass a regular function and not a component. Regular functions are usually defined inside components causing state to be lost on re-render if used as components. This warning is supposed to catch those cases.
- Causing pod install to abort - Match https://github.com/facebook/flipper/blob/main/react-native/ReactNativeFlipperExample/ios/Podfile
…10067) Calling `removeListener` on event that doesn't have any listeners will add new key for that event to listeners with value `undefined`. After that attempts to set `ref.current` will fail with "Cannot read property 'forEach' of undefined" error. Fix is quite simple. Just needed to add check if there is listeners for the given event. FYI @satya164. This is related to your recent change acdde18
- @react-navigation/bottom-tabs@6.1.0 - @react-navigation/core@6.1.1 - @react-navigation/devtools@6.0.5 - @react-navigation/drawer@6.2.0 - @react-navigation/elements@1.3.0 - flipper-plugin-react-navigation@1.3.8 - @react-navigation/material-bottom-tabs@6.1.0 - @react-navigation/material-top-tabs@6.1.0 - @react-navigation/native-stack@6.3.0 - @react-navigation/native@6.0.7 - @react-navigation/stack@6.1.0
Add `drawerAllowFontScaling` to the drawer options, so consumers can enable or disable font scaling for drawer labels to respect Text Size accessibility settings. The option functions similarly to [`tabBarAllowFontScaling`](tabBarAllowFontScaling). Co-authored-by: Kyle Edgette <kyle@join-real.com>
Added new prop `tabsOrDrawer` for `ScreenContainer` which makes `react-native-screens` on `iOS` use new component if it is available. See software-mansion/react-native-screens#1029 for context.
7 tasks
|
Hello, the PR got closed automatically due to some changes in the main branch. Would you be able to send a new PR? Thank you. |
|
Hey! This issue is closed and isn't watched by the core team. You are welcome to discuss the issue with others in this thread, but if you think this issue is still valid and needs to be tracked, please open a new issue with a repro. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adding options exposed to the
Screencomponent ofreact-native-screensin software-mansion/react-native-screens#863. It gives the user the ability to control orientation and status bar management per screen of the navigator.Changes:
NativeScreenTraitsPropstype to stack&drawer&tabs navigatorsreact-native-screensv3.3.0