Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix canDrop handling for inline combinators #703

Merged
merged 5 commits into from
May 23, 2024

Conversation

jakeboone02
Copy link
Member

Copy link

netlify bot commented May 21, 2024

Deploy Preview for react-querybuilder ready!

Name Link
🔨 Latest commit d3bbecc
🔍 Latest deploy log https://app.netlify.com/sites/react-querybuilder/deploys/664e7ae58ff85a000884de49
😎 Deploy Preview https://deploy-preview-703--react-querybuilder.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 69 (🟢 up 3 from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codesandbox-ci bot commented May 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d3bbecc:

Sandbox Source
React Query Builder CI Template Configuration
React Query Builder Basic Template Configuration
React Query Builder Basic TypeScript Template Configuration
React Query Builder Drag-and-drop Template Configuration
React Query Builder Ant Design Template Configuration
React Query Builder Bootstrap Template Configuration
React Query Builder Bulma Template Configuration
React Query Builder Chakra UI Template Configuration
React Query Builder Fluent UI Template Configuration
React Query Builder Mantine Template Configuration
React Query Builder MUI/Material Template Configuration
React Query Builder Native Template Configuration
React Query Builder Next.js Template Configuration
React Query Builder Tremor Template Configuration

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1465a4e) to head (d3bbecc).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #703   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          160       160           
  Lines         5033      5040    +7     
  Branches      2542      2528   -14     
=========================================
+ Hits          5033      5040    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakeboone02 jakeboone02 merged commit d3bbecc into main May 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline combinators do not respect canDrop result
1 participant