Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove invalid autocorrect attribute from textarea #80

Closed

Conversation

mbrookes
Copy link

Motivation

Fix an HTML validation error:

image

Test plan

Use https://validator.w3.org/nu/

Copy link
Collaborator

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prop was added in 4cc6ca3. It seems to be non-standard for Safari: https://stackoverflow.com/questions/47985384/html-autocorrect-for-text-input-not-working. I expect this attribute to no longer be relevant.

@satya164
Copy link
Collaborator

satya164 commented Feb 17, 2021

I expect this attribute to no longer be relevant.

@oliviertassinari why is that if safari still respects this attribute? did they remove support in recent versions?

@oliviertassinari
Copy link
Collaborator

oliviertassinari commented Feb 17, 2021

@satya164 From what I understand, the attribute autocorrect is supported for <input> but not for <textarea>.

@mbrookes The alternative is to not render react-simple-code-editor in the initial SSR phase, it might actually improve hydration performance by doing less work.

@satya164
Copy link
Collaborator

@oliviertassinari gotcha

@oliviertassinari oliviertassinari changed the title remove invalid autocorrect attribute from textarea fix: remove invalid autocorrect attribute from textarea Feb 18, 2021
@oliviertassinari
Copy link
Collaborator

Good for moving forward?

@oliviertassinari
Copy link
Collaborator

Actually, no, I have tested in iOS 12. It's still supported. It's a mess without. We need the attribute. I'm opening an issue in MDN and the HTML validator.

@oliviertassinari
Copy link
Collaborator

MDN: mdn/content#2534

@oliviertassinari
Copy link
Collaborator

oliviertassinari commented Feb 20, 2021

Validator: validator/validator#1089

whatwg/html#3595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants