-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autocorrect content attribute to HTMLElement #3595
Comments
@dtapuska any interest in helping with this? |
+1, I'm interested in this in Blink. /cc @yosinch |
I recommend also adding "no-punctuate" option, bringing options to off|on|no-punctuate. No-punctuate would imply that autocorrect is on, but removes the sometimes tedious problem of removing punctuation whenever two spaces are pressed. Currently, to disable this behavior, it's all or nothing at the OS level (detailed here: http://osxdaily.com/2012/07/03/stop-the-period-automatically-typing-in-ios/) |
Blink supports this on HTMLElement although the value isn't in the IDL; it is queried on the focused element.. See https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/editing/ime/InputMethodController.cpp?type=cs&l=1342 I support getting this spec'd. "on" and "off" are the only attribute values Blink supports (which appears to be case sensitive so there are likely some changes to Blink) |
Anyone know if an Ready to get started if there isn't already work being done. |
@jfbrennan that's probably best discussed in a separate issue. There's nothing on file that I know of. |
@annevk yes, will do. Thanks |
Autocorrect was working in blink (android) some time ago https://bugs.chromium.org/p/chromium/issues/detail?id=303883, but not now https://bugs.chromium.org/p/chromium/issues/detail?id=901839. |
We are about to add We're interested in getting this attribute into the spec if there is still multi-implementer interest. What is specifically needed for a concrete proposal? |
A spec PR would be ideal. |
The other thing that's needed is tests, as per https://whatwg.org/working-mode#changes. (Suspect Maciej is aware of this, but others might not be.) |
Someone from the WebKit team is looking at putting together a PR along the lines Domenic suggested, and I let them know that tests will also be expected for the PR to be approved, |
It's probably useful for content authors to turn off autocorrection for certain contexts, but iiuc the spec also will allow them to turn it on. In that case, how is the relationship between language/orthography and autocorrection handled? For example, i wouldn't want my input of Should the HTML spec have any text to indicate that autocorrection, if turned on, must take into consideration the language of the text around the form element? Would it make sense to go further, like CSS does for hyphenation, to say that it only works if a language is declared? Also, on a slightly different tack, should the spec allow or allude to a need for users to override the settings of the content author (eg. turn off AC if it is producing problems)? |
FWIW, iOS implementation doesn't turn off autocorrection if the user had manually turned it off. See the proposed spec text at whsieh@3214ff2#diff-36cd38f49b9afa08222c0dc9ebfe35ebR74483:
|
There's a concrete proposal now in #5841 , so removing the Adding |
Like
autocapitalize
,autocorrect
would turn on/off autocorrection on iOS. It would be good to have this iOS feature standardized.The text was updated successfully, but these errors were encountered: