Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace reconciler with renderer in doc #593

Merged
merged 1 commit into from Jul 25, 2020
Merged

Replace reconciler with renderer in doc #593

merged 1 commit into from Jul 25, 2020

Conversation

misterdev
Copy link
Contributor

Closes #588

@stephencorwin
Copy link
Member

stephencorwin commented Jul 25, 2020 •
edited

If we want to adopt/migrate to this new terminology, we should probably consider renaming reconciler.tsx to potentially renderer.tsx. I wanted to get further consensus from @drcmda before making a decision one way or the other. I can see the merit though in using the term "renderer". /shrug

@drcmda
Copy link
Member

drcmda commented Jul 25, 2020

sure, sounds like a plan. lets first merge this one ...

@drcmda drcmda merged commit aed6016 into pmndrs:master Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drcmda drcmda Awaiting requested review from drcmda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tweak the description
3 participants
@misterdev @stephencorwin @drcmda