Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to use Dart Sass instead of Node Sass #1621

Merged

Conversation

deiga
Copy link
Contributor

@deiga deiga commented Jun 30, 2021

Description

Migrate node-sass usage to Dart Sass library

Changes/Tasks

  • Changed dependencies

Motivation and Context

  • node-sass has been deprecated (https://sass-lang.com/blog/libsass-is-deprecated) and it is recommended to switch to use Dart Sass instead.
  • This allows users to actually use all SASS language features as node-sass has been lagging behind in feature parity for years.
  • This change is required for us to support Node 16

Screenshots (if appropriate):

Types of changes

  • Refactoring/add tests (refactoring or adding test which isn't a fix or add a feature)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have updated the documentation accordingly
  • I have updated the CHANGELOG with a summary of my changes
  • My changes have tests around them

Signed-off-by: Timo Sand <tsd@amboss.com>
Signed-off-by: Timo Sand <tsd@amboss.com>
Signed-off-by: Timo Sand <tsd@amboss.com>
@SleeplessByte
Copy link
Member

Thanks! ❤️

@SleeplessByte SleeplessByte merged commit 78e06cc into react-static:master Jun 30, 2021
@jeanlescure
Copy link

@deiga @SleeplessByte I think you guys forgot to release a new version of this plugin. It is still on 7.3.0 (which was released a year ago on npm). I was trying to use react-static-plugin-sass on a project under Node 16 but it breaks due to a problem on the old version of node-sass that the published version of react-static-plugin-sass depends on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants