Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 0.12.2 #38

Merged

Conversation

andrewliebchen
Copy link
Contributor

As requested in #36. I'm a designer/developer, so please double-check my work! 😄

Thanks for the great generator...I use it all the time!

@newtriks
Copy link
Member

newtriks commented Jan 7, 2015

Hi @andrewliebchen thank you for the pull request, I will review and merge asap 👍

newtriks added a commit that referenced this pull request Jan 9, 2015
@newtriks newtriks merged commit 3f83d1d into react-webpack-generators:master Jan 9, 2015
@victor-homyakov
Copy link
Contributor

Reach Router's API changed substantially, so app generated with routing does not work entirely
https://github.com/rackt/react-router/blob/master/UPGRADE_GUIDE.md#010x---011x

@andrewliebchen
Copy link
Contributor Author

Hmm, wonder if 0.10.x works with React 0.12.x.

@ColCh
Copy link
Contributor

ColCh commented Jan 9, 2015

6to5 supports jsx, so no jsx loader needed for es6 mode
@victor-homyakov yep You're right

@AlanVerbner
Copy link

As @victor-homyakov said, routes didn't work for me. I was getting _Uncaught TypeError: Cannot read property 'mockedReactClassConstructor' of undefined. Once I changed to this, I got it working:

var Router = require('react-router');
var Route = Router.Route;

var routes = (
    <Route handler={FluxTestApp}>
        <Route name="/" handler={FluxTestApp}/>
    </Route>
);

var content = document.getElementById('content');

Router.run(routes, Router.HistoryLocation, function (Handler) {
    React.render(<Handler/>, content);
});

// or default to hash location
Router.run(routes, function (Handler) {
    React.render(<Handler/>, content);
});

This is the first time I play around with React so I'm not sure if this is the correct solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants