Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the @Prop annotation with observable parameter #7

Merged
merged 6 commits into from
Oct 1, 2018

Conversation

realityforge
Copy link
Member

This makes it possible to control which props are observable. It also fixes a bug that failed to propagate props changes

@realityforge realityforge merged commit c8a1d21 into master Oct 1, 2018
@realityforge realityforge deleted the SelectivelyObserveProps branch October 1, 2018 07:01
@codecov-io
Copy link

codecov-io commented Oct 1, 2018

Codecov Report

Merging #7 into master will decrease coverage by 0.17%.
The diff coverage is 87.27%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master       #7      +/-   ##
============================================
- Coverage     93.14%   92.97%   -0.18%     
- Complexity      718      741      +23     
============================================
  Files            16       16              
  Lines          2042     2092      +50     
  Branches        348      360      +12     
============================================
+ Hits           1902     1945      +43     
- Misses           45       47       +2     
- Partials         95      100       +5
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/react4j/processor/PropDescriptor.java 91.66% <100%> (+0.36%) 25 <1> (+1) ⬆️
...rc/main/java/react4j/processor/ReactProcessor.java 89.19% <83.33%> (-0.17%) 289 <12> (+14)
...sor/src/main/java/react4j/processor/Generator.java 96.52% <88.57%> (-0.33%) 209 <4> (+8)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6601bf...9274f8c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants