Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button and LinkButton component created #86

Merged
merged 5 commits into from
Oct 25, 2022

Conversation

enowdivine
Copy link
Contributor

@enowdivine enowdivine commented Oct 14, 2022

Changes proposed

  • created the button component
  • created the LinkButton component

Check List (Check all the applicable boxes)

  • [ x] My code follows the code style of this project.
  • [ x] My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • [ x] This PR does not contain plagiarized content.
  • [ x] The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot from 2022-10-19 23-34-13

Screenshot from 2022-10-19 23-34-40

Note to reviewers

All requested changes have been made.

@vercel
Copy link

vercel bot commented Oct 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
reactdevske-website ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 5:53PM (UTC)

src/components/Button/Button.tsx Outdated Show resolved Hide resolved
src/components/Button/Button.tsx Outdated Show resolved Hide resolved
src/components/Button/Button.tsx Outdated Show resolved Hide resolved
src/components/Button/Button.tsx Outdated Show resolved Hide resolved
src/components/Button/Button.tsx Outdated Show resolved Hide resolved
src/components/LinkButton/LinkButton.tsx Outdated Show resolved Hide resolved
src/components/Button/Button.tsx Outdated Show resolved Hide resolved
src/components/Button/Button.tsx Outdated Show resolved Hide resolved
src/components/LinkButton/LinkButton.tsx Outdated Show resolved Hide resolved
@antosan antosan mentioned this pull request Oct 20, 2022
2 tasks
@enowdivine
Copy link
Contributor Author

Hi @antosan i just updated the PR.

@antosan
Copy link
Member

antosan commented Oct 24, 2022

Hi @antosan i just updated the PR.

Thanks @enowdivine Kindly remove the console log and we can merge this.

@enowdivine
Copy link
Contributor Author

Hello @antosan i just removed the console log. Sorry for the late response

Copy link
Member

@antosan antosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@antosan antosan added the hacktoberfest-accepted Hacktoberfest acceptance tag label Oct 24, 2022
@orama254 orama254 merged commit 865a942 into reactdeveloperske:develop Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hacktoberfest acceptance tag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the Button Component
3 participants