send nick change from irc to discord #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekmartin
approved these changes
May 16, 2017
lib/bot.js
Outdated
| @@ -125,6 +125,20 @@ class Bot { | |||
| this.sendToDiscord(author, to, `*${text}*`); | |||
| }); | |||
|
|
|||
| this.ircClient.on('nick', (oldnick, newnick, channels) => { | |||
There was a problem hiding this comment.
oldNick and newNick maybe? Nitpick :)
|
The only thing I would be wary about is if the library sends the list of channels containing every channel, like it does for quit, in which case this (I think) will send to all channels, even ones the user isn't in. I haven't actually tried it out in practice yet so this might be a nonissue. |
edited tests to reflect these changes
|
This should work fine, I think. |
Throne3d
approved these changes
May 16, 2017
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anoy discord user with the nick changes of the irc users