Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds customizing IRC nick colors in config #561

Merged
merged 1 commit into from
Sep 5, 2020

Conversation

KWeaver87
Copy link
Contributor

Addresses #560

@coveralls
Copy link

Coverage Status

Coverage decreased (-96.9%) to 0.0% when pulling be9b72e on KWeaver87:master into 56d1c84 on reactiflux:master.

@Throne3d
Copy link
Collaborator

Throne3d commented Sep 5, 2020

Hey there! Thanks for the contribution – this seems simple and easy, so I'm happy to merge it.

I'm not sure why coveralls reported a drop in the comment. It looks like maybe I misconfigured CI when moving to GitHub Actions, since there are two distinct checks listed, but one of them shows the correct slight increase. However, there was another recent PR from an external contributor that seemed to work fine. Weird!

@Throne3d Throne3d merged commit 5b01e76 into reactiflux:master Sep 5, 2020
@KWeaver87
Copy link
Contributor Author

No problem! Really just makes this easier on my end.
I was confused by the coveralls issue as well. I'm not familiar with it at all. But running coverage on my local gave me the 96%, so I assumed it was just something misconfigured somewhere. Glad it wasn't a big issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants