Added formatting conversions to messages #97
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…italics and underlining will now be converted between discord and IRC.
…support colorized text.
|
From a quick glance this looks really cool, thanks! Will do a more thorough review as fast as I have time :) |
| export function formatFromDiscordToIRC(text) { | ||
| // Apply formatting rules, from most specific to least specific. | ||
| return text.replace(/~~(.*?)~~/g, '$1') // Remove unsupported strikethrough | ||
| .replace(/__\*\*\*(.*?)\*\*\*__/g, '\u001F\u001D\u0002$1\u000F') // Apply underline-italics-bold |
There was a problem hiding this comment.
Maybe move \u0001F and similar to a constant? I.e.
const ircFormatCharacters = {
underline: '\u0001F',
// and so on
};
|
Thanks for the comments, you make good points. I'll try to address them as soon as I can. I don't have a lot of experience coding in Javascript, most of my time is spent in Python or Java, so I'm not really familiar with the specifics of the packages, especially the testing framework you're using. Nonetheless, I'll try to fix the issues soon! |
|
No problem, was just minor stuff :) |
|
Closing this due to inactivity. Feel free to reopen if you get time to fix the proposed changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added text formatting conversions to messages. Things like bold, italic and underscored text will be converted into their counterparts on the other service, and colors and strikethroughs will be stripped because they are unsupported on the other platform.
This would fix number 2 from issue #86 and issue #89.
For example on discord:
And on IRC: