This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sujith sujith@merchstack.com
Resolves #4
Impact: minor
Type: chore
Issue
Issue as mentioned in the ticket- Carts uses the TagSortByField and TagConnection type in GraphQL, which lives in the tags plugin. When work is done to move carts over here, we need to be sure to install api-plugin-tags as a peerDependency.
Solution
Just to ensure we are on same page, I am adding my understanding regarding peerDependency
An entry in peerDependency object of a plugin does NOT get installed by npm automatically. The entries has to be explicitly added as a dependency in the main package which is using the plugin and peerDependency gives out a warning if it is not done. Usually peerDependency is used in custom packages/plugins when a plugin works only with a specific version of a host package but if we are using a different version of the host package and add this plugin, then it generates a warning.
After updating the package.json, both "npm install" and "reaction develop" completed successfully.
Note
Noticed that the api-tags-plugin is using a function declared preStartup which is already declared in authorization-simple plugin.
Breaking changes
None.
Testing
After updating the package.json, pointed the cart-plugin to the updated version inside a new project and executed both "npm install" and "reaction develop". Both completed successfully.