Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production image is missing Sharp binary / Phyton #6

Closed
janus-reith opened this issue Nov 5, 2019 · 1 comment · Fixed by #7
Closed

Production image is missing Sharp binary / Phyton #6

janus-reith opened this issue Nov 5, 2019 · 1 comment · Fixed by #7
Assignees

Comments

@janus-reith
Copy link

The sharp binaries don't get included in the production build for 3.0.

RUN apk --no-cache --update add bash curl less shadow su-exec tini vim python2 make

includes an install step for python2 while
RUN apk --no-cache add bash curl less tini vim make

does not.

Python is required to build libvips.

@janus-reith
Copy link
Author

Also, I had to add a npm rebuild step to my Reaction Dockerfile so the modules were actually build.

@focusaurus focusaurus self-assigned this Nov 7, 2019
focusaurus added a commit that referenced this issue Nov 7, 2019
resolves #6

Signed-off-by: Peter Lyons <pete@reactioncommerce.com>
focusaurus added a commit that referenced this issue Nov 7, 2019
resolves #6

Signed-off-by: Peter Lyons <pete@reactioncommerce.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants