Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: developer concepts 2 #47

Closed

Conversation

MohanNarayana
Copy link
Contributor

Signed-off-by: Mohan Narayana mohan.narayana@mailchimp.com

brent-hoover and others added 3 commits November 30, 2021 14:22
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
Signed-off-by: Mohan Narayana <mohan.narayana@mailchimp.com>
Signed-off-by: Mohan Narayana <mohan.narayana@mailchimp.com>
Signed-off-by: Mohan Narayana <mohan.narayana@mailchimp.com>
Copy link
Collaborator

@brent-hoover brent-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be checked against the How-to guide and remove duplicates. Check against the original doc for what should be where

guides/developers-guide/concepts/dev-how-do-i.md Outdated Show resolved Hide resolved
Signed-off-by: Mohan Narayana <mohan.narayana@mailchimp.com>
Signed-off-by: Mohan Narayana <mohan.narayana@mailchimp.com>
Signed-off-by: Mohan Narayana <mohan.narayana@mailchimp.com>
@MohanNarayana
Copy link
Contributor Author

Doc for context is in this PR

Signed-off-by: Mohan Narayana <mohan.narayana@mailchimp.com>
Signed-off-by: Mohan Narayana <mohan.narayana@mailchimp.com>
@@ -0,0 +1,24 @@
# Schemas
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not a duplicate?

@@ -0,0 +1,91 @@
# App Events
Copy link
Collaborator

@brent-hoover brent-hoover Jan 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also a duplicate and also quite a big out of date

@delagroove delagroove added the reformat needs structural changes label Jan 25, 2022
@brent-hoover brent-hoover changed the base branch from new-docs-draft-one to new-docs-draft-two January 28, 2022 10:57
@brent-hoover
Copy link
Collaborator

Closing to be reopened in a later phase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reformat needs structural changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants