Skip to content

Commit

Permalink
fix: Correct redirects in auth flow; check for undefined paths
Browse files Browse the repository at this point in the history
  • Loading branch information
impactmass committed Sep 24, 2018
1 parent ef48099 commit ee705eb
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,24 +53,24 @@ app
server.use(cookieParser());

server.get("/signin", (req, res, next) => {
if (!req.user) req.session.redirectTo = req.get("Referer");
req.session.redirectTo = req.get("Referer");
next(); // eslint-disable-line promise/no-callback-in-promise
}, passport.authenticate("oauth2", { loginAction: "signin" }));

server.get("/signup", (req, res, next) => {
if (!req.user) req.session.redirectTo = req.get("Referer");
req.session.redirectTo = req.get("Referer");
next(); // eslint-disable-line promise/no-callback-in-promise
}, passport.authenticate("oauth2", { loginAction: "signup" }));

// This endpoint handles OAuth2 requests (exchanges code for token)
server.get("/callback", passport.authenticate("oauth2"), (req, res) => {
// After success, redirect to the page we came from originally
res.redirect(req.session.redirectTo);
res.redirect(req.session.redirectTo || "/");
});

server.get("/logout", (req, res) => {
req.logout();
res.redirect(req.get("Referer"));
res.redirect(req.get("Referer") || "/");
});

// Setup next routes
Expand Down

0 comments on commit ee705eb

Please sign in to comment.