Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: numbering bug #337

Merged
merged 1 commit into from
Sep 25, 2018
Merged

docs: numbering bug #337

merged 1 commit into from
Sep 25, 2018

Conversation

machikoyasuda
Copy link
Contributor

@machikoyasuda machikoyasuda commented Sep 25, 2018 •
edited
Loading

Impact: minor
Type: docs

Issue

The steps were not numbered correctly in Markdown

Solution

Manually incremented steps.

Testing

  1. Look at this rendered tab --> https://github.com/reactioncommerce/reaction-next-starterkit/blob/3e78790e6120690e9cd87aa96d1d24fbc0500fa9/README.md#getting-started
  2. Compare with the current rendered Markdown --> https://github.com/reactioncommerce/reaction-next-starterkit#getting-started

willopez
willopez approved these changes Sep 25, 2018
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willopez willopez merged commit 0419ffb into develop Sep 25, 2018
@machikoyasuda machikoyasuda deleted the machikoyasuda-patch-1 branch September 25, 2018 22:55
This was referenced Jan 15, 2019
Closed
Merged
@spencern spencern mentioned this pull request Jan 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willopez willopez willopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@machikoyasuda @willopez