Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add padding to cart items in order complete page #338

Merged
merged 3 commits into from
Sep 26, 2018

Conversation

willopez
Copy link
Member

Resolves #334
Impact: minor
Type: bugfix

Summary

Add padding to cart items in order complete page.

Testing

  1. Verify cart items have padding, compare with designs.

Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI test is failing, possibly just needs snapshot updated

Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willopez Looking at the code change I think this is fine to merge, I've been unable to test it locally because I keep running into a Cannot read property 'card' of undefined error when trying to check out. Deff a problem with my setup I'm going to restart and test again but if you want to merge I think it's good2go.

@willopez
Copy link
Member Author

@nnnnat that error will occur when you don't have a stripe token, which in turn means that you might not have the stripe API keys configured in reaction + staterkit https://github.com/reactioncommerce/reaction-next-starterkit#set-up-stripe

Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willopez haha yeah I had Stripe set up in RC but not the starterkit. Was able to test locally looks good!

@nnnnat nnnnat merged commit 572b165 into develop Sep 26, 2018
@nnnnat nnnnat deleted the fix-padding-on-order-complete-page branch September 26, 2018 15:28
This was referenced Jan 15, 2019
@spencern spencern mentioned this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Padding is missing in cart items in the completed order page.
2 participants