Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unsplit first and last name fields in Checkout saving #386

Merged
merged 3 commits into from
Oct 12, 2018

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Oct 12, 2018

Impact: minor
Type: refactor

Issue

The way we save names is a little funky. We have our forms split into firstName and lastName fields, but we save names inside the data as fullName. We do this by combining the firstName and lastName fields inside the starterkit.

Solution

We need to update the form to accept a single fullName field, instead of two fields which are combined into a single field. This update fixes the issue in the starterkits mutation of the data. An update to the component library will also be made to make the fields into a single field.

Breaking changes

I don't expect any breaking changes, as the two fields are combined into the single field anyway on the backend.

Testing

See that fullName data is saved correctly in cart.shippings.address.fullName one the Component library PR is merged.

@kieckhafer kieckhafer changed the title [WIP] refactor: unsplit first and last name fields in Checkout saving refactor: remove unsplitting of name fields in setShippingAddress function Oct 12, 2018
@kieckhafer kieckhafer changed the title refactor: remove unsplitting of name fields in setShippingAddress function refactor: unsplit first and last name fields in Checkout saving Oct 12, 2018
Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nnnnat nnnnat merged commit 0ea2201 into develop Oct 12, 2018
@nnnnat nnnnat deleted the ref-kieckhafer-checkoutActionsAddress branch October 12, 2018 23:17
This was referenced Jan 15, 2019
@spencern spencern mentioned this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants