refactor: unsplit first and last name fields in Checkout saving #386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: minor
Type: refactor
Issue
The way we save names is a little funky. We have our forms split into
firstName
andlastName
fields, but we save names inside the data asfullName
. We do this by combining thefirstName
andlastName
fields inside the starterkit.Solution
We need to update the form to accept a single
fullName
field, instead of two fields which are combined into a single field. This update fixes the issue in the starterkits mutation of the data. An update to the component library will also be made to make the fields into a single field.Breaking changes
I don't expect any breaking changes, as the two fields are combined into the single field anyway on the backend.
Testing
See that fullName data is saved correctly in
cart.shippings.address.fullName
one the Component library PR is merged.