Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unused scopes and grant_type #390

Merged
merged 2 commits into from
Oct 15, 2018
Merged

Conversation

impactmass
Copy link
Contributor

@impactmass impactmass commented Oct 15, 2018

Related to reactioncommerce/reaction#4733
and #350
Impact: minor

Issue

Our initial Hydra bootstrap settings contains some extra fields that are not in use. These are: (i) the openid scope that leads to the issuance of and id_token (ii) Extra OAuth 2 Grant Types for the starterkit client.

Solution

  • Remove the scope for id-token. This can be added back intentionally when we decide how we want to use the id-token across our system. Prevent possible leak of tokens. Prevent confusion around what the scopes are for.
  • Remove the unused grant types, and limit to only the ones of use.

Breaking changes

N/A - Previous functionality works as before

Testing

NB: There is a current bug in Starterkit's Component library version. Set the version to "@reactioncommerce/components": "0.43.0", in your package.json.

  1. Run this branch against the Hydra service with no client for starterkit yet. If necessary, you can remove the existing one with $ docker-compose run --rm -e "HYDRA_ADMIN_URL=http://hydra:4445" hydra clients delete reaction-next-starterkit
  2. Starting the app should (re)create the Hydra client with the new configuration
  3. Run your reaction service with this PR branch Fix Auth Consent scopes issue reaction#4733
  4. Confirm that your login works as usual

Reference Links:

@impactmass impactmass changed the title [WIP] fix: Remove unused scopes and grant_type fix: Remove unused scopes and grant_type Oct 15, 2018
@impactmass impactmass added this to the Oxford milestone Oct 15, 2018
@rosshadden rosshadden merged commit ffe5328 into develop Oct 15, 2018
@rosshadden rosshadden deleted the remove-unused-scope branch October 15, 2018 19:58
This was referenced Jan 15, 2019
@spencern spencern mentioned this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants