-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable/Disable Single-page app routing #419
Conversation
@mikemurray thinking about the new ENABLE_SPA_LINKS env; should it have a default value |
@impactmass then maybe |
@impactmass I ended up leaving the I also fixed the prop-type warning you were seeing. Now on to fixing the broken tests. |
@impactmass ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and the full pages loads as described when enabled.
I have a note about the env setup. It feels like a global project concern, but wanted to point it out
@impactmass updated the logic and added a comment. Ready for review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving.
It would be good to revisit the env setup later.
Resolves #417
Impact: minor
Type: feature
Issue
Description of the issue this PR is solving, why it's happening, and how to reproduce it. This may differ from the original ticket as you now have more information at your disposal.
Solution
Breaking changes
ENABLE_SPA_LINKS=true
should be placed in your.env
fileTesting
With
ENABLE_SPA_LINKS=true
With
ENABLE_SPA_LINKS=false