chore: Add logger messages for 401 error #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
impactmass
changed the title
|
@impactmass Needs rebase to resolve conflicts now |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: NA
Impact: minor
Type: chore
Issue
When loading the app after a previous authenticated session and the auth token is expired, the app shows a blank screen. The starterkit server logs shows an error about other failures but not explicit about the 401.
Looking in the browser network tab can help, as the 401 can be seen there.
The Reaction API service logs shows the
Bearer token is not activeerror; but it helps to have it logged here too.Solution
Add proper logs that reflect the actual problem (pending when automatic refresh is resolved #350)
Testing
@Akarshit adding you as reviewer because you ran into this recently. There's really nothing to test other than confirming that the logged message helps to know the actual issue (and prevents getting stuck).