Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: NA
Impact: minor
Type: bugfix
Issue
const logger = require("lib/logger");
logger.debug("")
==> debug is not a functionSolution
In the express app, the exported Logger is custom and only has
error
andappStarted
methods. It is different from https://github.com/reactioncommerce/logger.Solution: Switch to plain console.log instead.
Testing
Extra Update
Also, we have a JSON.parse() that should be wrapped in a try/catch block to prevent exception failure. This PR also wraps that in a try/catch block. To test, just confirm that usual app usage works without errors.