Obey url rewrites in browser-side routing #463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #452
Impact: minor
Type: feature
Issue
Rewrite rules by nature mask the actual URL the underlying application uses for routing. This is problematic when dealing with single-page app routing as it has no idea that route exists, resulting in 404's.
Solution
Update starter-kit to accept a
Request-Path
from the proxy handling the rewrite rules in order to make a new route entry in the browser-side app.Breaking changes
none.
Testing
/example/route
to:/tag/shop
localhost:9090/example/route
/example/route