Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obey url rewrites in browser-side routing #463

Merged
merged 6 commits into from Jan 10, 2019

Conversation

mikemurray
Copy link
Member

@mikemurray mikemurray commented Dec 17, 2018

Resolves #452
Impact: minor
Type: feature

Issue

Rewrite rules by nature mask the actual URL the underlying application uses for routing. This is problematic when dealing with single-page app routing as it has no idea that route exists, resulting in 404's.

Solution

Update starter-kit to accept a Request-Path from the proxy handling the rewrite rules in order to make a new route entry in the browser-side app.

Breaking changes

none.

Testing

  1. With the reaction platform, and steps outlined in other repos
  2. Start reaction platform
  3. In the Redirect URLs admin panel, add a new rewrite rule for a tag page
  4. For example from: /example/route to: /tag/shop
  5. Navigate to localhost:9090/example/route
  6. See the tag page you expect
  7. Adjust the page limit/price filters
  8. See that the URL in the address bar remains /example/route

@mikemurray mikemurray changed the title [WIP] Obey url rewrites in browser-side routing Obey url rewrites in browser-side routing Dec 17, 2018
@mikemurray
Copy link
Member Author

mikemurray commented Dec 17, 2018

@rosshadden You are the "does this make sense?" reviewer.
@machikoyasuda you are the primary reviewer as this relates to tags.

@ross
Copy link

ross commented Dec 17, 2018

@ross You are the "does this make sense?" reviewer.

Looks like you want @rosshadden here.

@mikemurray
Copy link
Member Author

Thanks @ross!

@machikoyasuda machikoyasuda merged commit 8055c97 into develop Jan 10, 2019
@machikoyasuda machikoyasuda deleted the feat-452-mikemurray-rewrites branch January 10, 2019 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants