Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0.0] Fix params for withTag API query #621

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Dec 3, 2019

Resolves #620
Impact: minor
Type: bugfix

Issue

Due to breaking changes in the 3.0 tag GraphQL query, the example storefront does not load.

Solution

Update client query to match API.

Breaking changes

Yes, this won't work with 2.x API, but this is the 3.0 branch.

Testing

Verify storefront loads in browser when connected with release-3.0.0 branch of API, and you don't see any errors in the API or storefront server logs.

Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed aldeed requested a review from willopez December 3, 2019 20:00
@aldeed aldeed added this to In progress in 3.0.0 via automation Dec 3, 2019
@aldeed aldeed moved this from In progress to Review in progress in 3.0.0 Dec 3, 2019
@aldeed aldeed requested review from mikemurray and removed request for willopez December 3, 2019 21:38
Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

3.0.0 automation moved this from Review in progress to Reviewer approved Dec 3, 2019
@mikemurray mikemurray merged commit 2c7d663 into release-v3.0.0 Dec 3, 2019
3.0.0 automation moved this from Reviewer approved to Done Dec 3, 2019
@mikemurray mikemurray deleted the fix-aldeed-tags-api-params branch December 3, 2019 22:02
@kieckhafer kieckhafer mentioned this pull request Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
3.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants