Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto-create Hydra client on startup #628

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Dec 13, 2019

Impact: minor
Type: feature

Changes

For local development, there is a script that runs before the application, which creates a Hydra client for the storefront if one does not yet exist. However, this script isn't included in the production image and doesn't run in a production environment, leading to an additional task that a system admin has to do for every new environment.

This PR moves the auto-creation of the Hydra client to be part of the server startup code, such that it runs in all environments always.

Breaking changes

None

Testing

  1. In reaction-hydra, docker-compose down -v and then docker-compose up -d. This will ensure the Hydra database is empty and has no clients.
  2. Start/restart the example storefront and verify you see logging about the Hydra client being created.
  3. Restart the example storefront and verify you see logging about the Hydra client already existing.

Perform above steps both with and without the docker-compose.dev override.

Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed aldeed added this to In progress in 3.0.0 via automation Dec 13, 2019
@aldeed aldeed moved this from In progress to Review in progress in 3.0.0 Dec 13, 2019
Copy link
Contributor

@rosshadden rosshadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me and looks good.

3.0.0 automation moved this from Review in progress to Reviewer approved Dec 16, 2019
@aldeed aldeed merged commit ac0d967 into release-v3.0.0 Dec 16, 2019
3.0.0 automation moved this from Reviewer approved to Done Dec 16, 2019
@aldeed aldeed deleted the feat-aldeed-auto-create-hydra-client branch December 16, 2019 17:01
@kieckhafer kieckhafer mentioned this pull request Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
3.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants