Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: login from storefront #633

Merged
merged 2 commits into from
Dec 19, 2019

Conversation

kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Dec 19, 2019

See reactioncommerce/reaction#5951

Impact: critical
Type: bugfix

You need to be this branch of Reaction when testing. That PR and this one should be merged at the same time.

Issue

Account login was not working when trying to login via example storefront.

Solution

Add oauth login method to new AuthContainer. This is how we used to do oauth login in the past, when we used OauthContainer, but this was removed / with the new AuthContainer.

Breaking changes

None

Testing

  1. Start the full app (reaction (fix: login from storefront reaction#5951) / storefront)
  2. Navigate to storefront
  3. Login
  4. See you are redirected back to storefront, and you are logged in
  5. Logout
  6. See you are redirected back to storefront, and are logged out

Signed-off-by: Erik Kieckhafer <ek@ato.la>
Signed-off-by: Erik Kieckhafer <ek@ato.la>
Copy link
Member

@manueldelreal manueldelreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@manueldelreal manueldelreal merged commit 87ad69a into release-2.9.1 Dec 19, 2019
@rosshadden rosshadden deleted the fix-kieckhafer-loginFromStorefront branch December 19, 2019 20:22
@rosshadden rosshadden mentioned this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants