fix: special characters in variables #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l characters Signed-off-by: Ross Hadden <rosshadden@gmail.com>
aldeed
approved these changes
Jan 2, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #638
Impact: minor
Type: bugfix
Issue
The
bin/setupscript doesn't handle special characters. Noticed examples are$and&.Solution
Used
commandinstead ofeval. There are a lot of reasons for this, andevalis generally frowned-upon. One such reason is it breaks when given "dirty" data.Breaking changes
I don't think there are any breaking changes with this.
Testing
Run
bin/setupand make sure everything is working as expected. I don't have an exhaustive list of what all that may be.