Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update query with required shopIds array #656

Merged
merged 1 commit into from
Feb 3, 2020
Merged

fix: update query with required shopIds array #656

merged 1 commit into from
Feb 3, 2020

Conversation

kieckhafer
Copy link
Member

Resolves #655
Impact: major
Type: bugfix

Issue

Profile orders page doesn't load. Shows "500". There is an ordersByAccountId GraphQL error in the server logs:

Solution

Update GQL query to use correct variables.

Breaking changes

None

Testing

  1. Create an order
  2. Go to http://localhost:4000/profile/orders while logged in with user who created order
  3. See the order page, not an error

@kieckhafer
fix: update query with required shopIds array
359fd9e 
Signed-off-by: Erik Kieckhafer <ek@ato.la>
@aldeed aldeed added this to In progress in 3.0.0 via automation Feb 2, 2020
@aldeed aldeed moved this from In progress to Review in progress in 3.0.0 Feb 2, 2020
3.0.0 automation moved this from Review in progress to Reviewer approved Feb 3, 2020
@aldeed aldeed merged commit 3fd4cd5 into release-v3.0.0 Feb 3, 2020
3.0.0 automation moved this from Reviewer approved to Done Feb 3, 2020
@aldeed aldeed deleted the fix-kieckhafer-profileOrderPageError branch February 3, 2020 22:23
This was referenced Feb 4, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldeed aldeed aldeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
3.0.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kieckhafer @aldeed